NumberToWord Turkish implementation #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumberToWord implementation with unit tests
mexx
added a commit
that referenced
this pull request
Jul 3, 2014
| var hundred = (number / 100); | ||
| if (hundred > 0) | ||
| { | ||
| parts.Add(string.Format("{0} yüz", hundred > 1 ? Convert(number / 100) : "").Trim()); |
There was a problem hiding this comment.
you could reuse the already calculated hundred value
|
@erdemergin I've merged the PR already and found the code issues afterwards, can you address them in a new PR. |
| @@ -2,6 +2,7 @@ | |||
| - [#306](https://github.com/MehdiK/Humanizer/pull/306): Added Singularize/Pluralize overload without using obsolete plurality enum | |||
| - [#303](https://github.com/MehdiK/Humanizer/pull/303): Added support for all integer types in ByteSize extensions | |||
| - [#307](https://github.com/MehdiK/Humanizer/pull/307): Added support to string.FormatWith for the explicit culture parameter. | |||
| - [#312](https://github.com/MehdiK/Humanizer/pull/312): Added Turkish NumberToWord implementation | |||
There was a problem hiding this comment.
I think we should indicate that Ordinalizer is added too.
|
@mexx That's cool. Thanks for tackling it |
| var wordChars = word.ToCharArray().Reverse().ToArray(); | ||
| var suffixFoundOnLastVowel = false; | ||
|
|
||
| for (int i = 0; i < wordChars.Count(); i++) |
There was a problem hiding this comment.
you can iterate in reverse order over the word
for (var i = word.Length - 1; i >= 0; i--)
and you can remove the copy wordChars
|
@erdemergin As I was to fast at merging it, I've corrected the problems mentioned after the merge. |
|
This is now available on NuGet as v1.28.0. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberToWord Turkish implementation with unit tests